Homec4science

Herald - add support for application emails.

Authored by Bob Trahan <btrahan@phacility.com> on Jan 29 2015, 23:15.

Description

Herald - add support for application emails.

Summary:
Fixes T5039. The trick / possibly lame part here is we only match 1 application email and its undefined which one. e.g. if a user emails us at address x, y, and z only one of those will pick up the mail. Ergo, don't let users define non-sensical herald conditions like "matches all". Also document what I think was non-intuitive about the code with an inline comment; we have to return an array with just a phid from an object and out of context it feels very "what the...???"

Note this needs to be deployed to other applications still, but I think its okay to close T5039 aggressively here since its done from a user story perspective.

Test Plan: set up a herald rule to flag tasks created as blue via app email x. sent an email to x via bin/mail receive-test and verified the task had the blue flag

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5039

Differential Revision: https://secure.phabricator.com/D11564

Details

Committed
Bob Trahan <btrahan@phacility.com>Jan 29 2015, 23:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPHffaed67711dc: Fix default-public-author migration script
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHab8f7907dee8: Herald - add support for application emails. (authored by Bob Trahan <btrahan@phacility.com>).Jan 29 2015, 23:15