Homec4science

Extend PhabricatorPolicyQuery from PhabricatorOffsetPagedQuery

Authored by epriestley <git@epriestley.com> on Aug 8 2012, 21:15.

Description

Extend PhabricatorPolicyQuery from PhabricatorOffsetPagedQuery

Summary:
A few goals here:

  • Slightly simplify the Query classtree -- it's now linear: Query -> OffsetPagedQuery (adds offset/limit) -> PolicyQuery (adds policy filtering) -> CursorPagedPolicyQuery (adds cursors).
  • Allow us to move from non-policy queries to policy queries without any backward compatibility breaks, e.g. Conduit methods which accept 'offset'.
  • Separate the client limit ("limit") from the datafetch hint limit ("rawresultlimit") so we can make the heurstic smarter in the future if we want. Some discussion inline.

Test Plan: Expanded unit tests to cover offset behaviors.

Reviewers: vrana, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D3192

Details

Committed
epriestley <git@epriestley.com>Aug 8 2012, 21:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8a4c08b01db0: Allow commits to be associated with projects and associated goodies
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHab92242e00b3: Extend PhabricatorPolicyQuery from PhabricatorOffsetPagedQuery (authored by epriestley <git@epriestley.com>).Aug 8 2012, 21:15