Homec4science

Transactions - fix bug in differential where older inlines weren't appearing

Authored by Bob Trahan <btrahan@phacility.com> on Dec 5 2014, 20:15.

Description

Transactions - fix bug in differential where older inlines weren't appearing

Summary: Fixes T6699. We need to "loadInlineComments" consistently, though for an unexpected reason - this mutates the $changesets to include all $changesets that have an associated inline comment, which is necessary to make them render properly.

Test Plan: Took a diff with inline comments and updated it, noting the inline comments disappeared. applied this patch and the inlines reappeared.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6699

Differential Revision: https://secure.phabricator.com/D10935

Details

Committed
Bob Trahan <btrahan@phacility.com>Dec 5 2014, 20:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH39351f0a5abc: Remove unused sprite image
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHac1c9559860b: Transactions - fix bug in differential where older inlines weren't appearing (authored by Bob Trahan <btrahan@phacility.com>).Dec 5 2014, 20:15