Homec4science

Don't try to select a nav item if the selected item is explicitly null

Authored by epriestley <git@epriestley.com> on Jan 14 2013, 21:39.

Description

Don't try to select a nav item if the selected item is explicitly null

Summary: If there are items (like labels) without keys, we incorrectly select the first item with no key in response to a selectFilter(null) call.

Test Plan: Called selectFilter(null), didn't get a selected label.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D4428

Details

Committed
epriestley <git@epriestley.com>Jan 14 2013, 21:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9470ab057640: First go at Files settings.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHac5520e08927: Don't try to select a nav item if the selected item is explicitly null (authored by epriestley <git@epriestley.com>).Jan 14 2013, 21:39