Homec4science

Fix overzealous transactions on dashboard panels

Authored by epriestley <git@epriestley.com> on Mar 3 2016, 14:46.

Description

Fix overzealous transactions on dashboard panels

Summary: Fixes T10474. This had the same root cause as T10024 -- a missing call to didSetValueFromStorage() because of the way the fields work.

Test Plan:

  • Edited a text panel before change, without changing text: got silly transaction.
  • Made change, edited text panel without changing text, no transaction.
  • Made a real edit, got a good transaction.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10474

Differential Revision: https://secure.phabricator.com/D15391

Details

Committed
epriestley <git@epriestley.com>Mar 3 2016, 16:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPH61c45e4927a0: Update Calendar for PHUITwoColumnView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHac729278328e: Fix overzealous transactions on dashboard panels (authored by epriestley <git@epriestley.com>).Mar 3 2016, 16:35