Homec4science

Correctly handle downloading ZIP with empty directories in Phragment

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Dec 8 2013, 02:15.

Description

Correctly handle downloading ZIP with empty directories in Phragment

Summary: This logic causes an exception because getPHID() is called on a fragment that has no latest version. This fixes the code so that in this scenario, it returns an empty array (with no path to be added to the ZIP).

Test Plan: Downloaded the ZIP successfully after the patch was applied.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4205

Differential Revision: https://secure.phabricator.com/D7735

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Dec 8 2013, 02:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc48cfb31bc76: Implement viewing versions and downloading patches in Phragment
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPHacd5d5ae4a39: Correctly handle downloading ZIP with empty directories in Phragment (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Dec 8 2013, 02:15