Homec4science

Reject Phame domains which include a port number

Authored by epriestley <git@epriestley.com> on Mar 11 2014, 23:53.

Description

Reject Phame domains which include a port number

Summary: Via HackerOne. This doesn't actually have any security impact as far as we can tell, but a researcher reported it since it seems suspicious. At a minimum, it could be confusing. Also improve some i18n stuff.

Test Plan: Hit all the error cases, then saved a valid custom domain.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Differential Revision: https://secure.phabricator.com/D8493

Details

Committed
epriestley <git@epriestley.com>Mar 11 2014, 23:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH740757fd9b7a: Diffusion - add ToC for readme files
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHad88ff28a1b5: Reject Phame domains which include a port number (authored by epriestley <git@epriestley.com>).Mar 11 2014, 23:53