Homec4science

robustify Differential and Maniphest mailhandlers wrt attachments

Authored by Bob Trahan <bob.trahan@gmail.com> on Nov 1 2012, 23:18.

Description

robustify Differential and Maniphest mailhandlers wrt attachments

Summary:
a few things

  • make the parent mailhandler class not send "blank body" error if you have attachments
  • make both differential and maniphest append a list of attachments to the body if any exist
  • BONUS - made the cc stuff work in Maniphest

Test Plan: I haven't actually tested this yet. :( i need to figure out how to send a mail with an attachment from the command-line and figured I'd serve this up first.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2012

Differential Revision: https://secure.phabricator.com/D3868

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Nov 1 2012, 23:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe0b9a6338881: make Differential comment panel flexible width and nip a bit at other flexible…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHafae26ad941a: robustify Differential and Maniphest mailhandlers wrt attachments (authored by Bob Trahan <bob.trahan@gmail.com>).Nov 1 2012, 23:18