Homec4science

Fix resolution of commits in SVN repositories without callsigns

Authored by epriestley <git@epriestley.com> on Apr 4 2016, 18:40.

Description

Fix resolution of commits in SVN repositories without callsigns

Summary:
Fixes T10721. When trying to load commits by identifier, we would take some bad pathways in Subversion if the repository had no callsign and end up missing the commits.

Fix this logic so it works for either callsigns (e.g., if passed rXyyy) or with PHIDs if passed repositories.

Test Plan:

  • Viewed SVN commit in a Subversion repository with no callsign.
  • Added a callsign, looked at it again.
  • Viewed non-SVN commits in callsign and non-callsign repositories.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10721

Differential Revision: https://secure.phabricator.com/D15607

Details

Committed
epriestley <git@epriestley.com>Apr 4 2016, 18:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5f957807a725: Update OAuthServer for modern SearchEngine fields
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb07a524b4b07: Fix resolution of commits in SVN repositories without callsigns (authored by epriestley <git@epriestley.com>).Apr 4 2016, 18:44