Homec4science

Filter only possibly-tainted keys from superglobals

Authored by Eric Stern <firehed@gmail.com> on Aug 5 2013, 20:45.

Description

Filter only possibly-tainted keys from superglobals

Summary: Ensures that weird behavior from filter_input_array does not remove keys from superglobals. Should fix T3677.

Test Plan:
Checked that $_SERVER contained same number of keys before and after
filtering, and that those affected by the original bug continue to be filtered
correctly.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: zorfling, aran, Korvin, wez

Maniphest Tasks: T3677

Differential Revision: https://secure.phabricator.com/D6680

Details

Committed
epriestley <git@epriestley.com>Aug 5 2013, 20:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb712905dc1b1: Add a "document" style to PHUIRemarkupPreviewPanel and use it in Legalpad and…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb20a0eed13cf: Filter only possibly-tainted keys from superglobals (authored by Eric Stern <firehed@gmail.com>).Aug 5 2013, 20:45