Homec4science

Fix handling of implicit comment transaction in paste creation

Authored by epriestley <git@epriestley.com> on Nov 25 2015, 17:21.

Description

Fix handling of implicit comment transaction in paste creation

Summary:
Fixes T9850. The getComment() test should be a hasComment() test, in order to discard empty comments.

Also backport a couple of future fixes which can get you into trouble if you reconfigure forms in awkward ways.

Test Plan: Created a new paste without a comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9850

Differential Revision: https://secure.phabricator.com/D14571

Details

Committed
epriestley <git@epriestley.com>Nov 25 2015, 17:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc4ea1e6e21d1: Increase the maximum size eligible for image transforms configurable from 4MB…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb21928599960: Fix handling of implicit comment transaction in paste creation (authored by epriestley <git@epriestley.com>).Nov 25 2015, 17:25