Homec4science

When Favorites is uninstalled or not visible to the viewer, hide the menu

Authored by epriestley <git@epriestley.com> on Jan 18 2017, 15:05.

Description

When Favorites is uninstalled or not visible to the viewer, hide the menu

Summary: Ref T5867. The executeOne() currently raises a policy exception if the application isn't visible to the viewer, or we fatal if the application has been uninstalled.

Test Plan:

  • Viewed pages with the application uninstalled, saw working pages with no favorites menu.
  • Viewed pages with the application restricted, saw working pages with no favorites menu.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T5867

Differential Revision: https://secure.phabricator.com/D17219

Details

Committed
epriestley <git@epriestley.com>Jan 18 2017, 16:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0513a242352e: Fix a bad constant in "audit.query"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb21cd24341c6: When Favorites is uninstalled or not visible to the viewer, hide the menu (authored by epriestley <git@epriestley.com>).Jan 18 2017, 16:45