Homec4science

Add "final" to all Phabricator "Controller" classes

Authored by epriestley <git@epriestley.com> on Mar 10 2012, 00:46.

Description

Add "final" to all Phabricator "Controller" classes

Summary:
These are all unambiguously unextensible. Issues I hit:

  • Maniphest Change/Diff controllers, just consolidated them.
  • Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects.
  • D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962.

Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from final classes. Resolved issues.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1843

Details

Committed
epriestley <git@epriestley.com>Mar 10 2012, 00:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1bff43a0c3d9: Mask a couple more config keys
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb2890eeb0e6f: Add "final" to all Phabricator "Controller" classes (authored by epriestley <git@epriestley.com>).Mar 10 2012, 00:46