Render commit summaries when rendering handles
b32bfb654163
Actions

Authored by epriestley <git@epriestley.com> on Feb 22 2013, 00:09.

Description

Render commit summaries when rendering handles

Summary:
Fixes T2563. Instead of rendering "rPnnnnnn", render "rPnnnnnn: add feature X". Tweak Audit tables to accommodate.

@vrana / @nh, this migration might take a while. You could safely skip it when deploying and then run it after deployment.

I think I fixed all the other places where these render, but might have missed something.

Test Plan:

Ran first schema migration, clicked around to make sure nothing broke.
Ran scripts/repository/reparse.php --message rXyyyyy, verified summary populated.
Ran second migration.
Checked task/diffusion/audit/differential for weird rendering.

Reviewers: vrana

Reviewed By: vrana

CC: nh, aran, chrisbolt, allixsenos

Maniphest Tasks: T2563

Committed

epriestley <git@epriestley.com>

Feb 22 2013, 00:09

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPHb32bfb654163: Render commit summaries when rendering handles (authored by epriestley <git@epriestley.com>).Feb 22 2013, 00:09

				Path
	A			resources/sql/patches/20130219.commitsummary.sql
	A			resources/sql/patches/20130219.commitsummarymig.php
	M			src/applications/audit/view/PhabricatorAuditCommitListView.php
	M			src/applications/audit/view/PhabricatorAuditListView.php
	M			src/applications/diffusion/controller/DiffusionCommitController.php
	M			src/applications/phid/PhabricatorObjectHandle.php
	M			src/applications/phid/handle/PhabricatorObjectHandleData.php
	M			src/applications/repository/storage/PhabricatorRepositoryCommit.php
	M			src/applications/repository/storage/PhabricatorRepositoryCommitData.php
	M			src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
	M			src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php