Homec4science

Fix Differential "unsubscribe" so it properly blocks resubscription

Authored by epriestley <git@epriestley.com> on Apr 30 2011, 07:26.

Description

Fix Differential "unsubscribe" so it properly blocks resubscription

Summary:
DifferentialRevision stores this field as a dictionary but the
Editor incorrectly passed it to Herald as a raw value array. Ideally the
property should be called unsubscribedDict or something but I'm increasingly
thinking we're going to centralize subscriptions for Adjutant or some similar
system so I'm disinclined to pursue the schema change just yet. I provided an
explicit raw-value-oriented API, at least.

Test Plan:
With two accounts, A and B: created universal Herald CC rule with
user B, created a revision with user A, had user B unsubscribe, had user A
update the revision. User B was not resubscribed.

Reviewed By: aran
Reviewers: jungejason, tuomaspelkonen, aran
CC: ola, aran, epriestley
Differential Revision: 188

Details

Committed
epriestley <git@epriestley.com>Apr 30 2011, 07:31
Pushed
aubortJan 31 2017, 17:16
Parents
rPH864e0d8a2fad: Fix XSS hole in inline comment editing
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb3397030e6c9: Fix Differential "unsubscribe" so it properly blocks resubscription (authored by epriestley <git@epriestley.com>).Apr 30 2011, 07:31