Homec4science

Don't stop on read-only mode for read-only storage workflows

Authored by epriestley <git@epriestley.com> on May 30 2016, 17:30.

Description

Don't stop on read-only mode for read-only storage workflows

Summary:
Fixes T11042. Currently, all bin/storage workflows stop if cluster.read-only is set:

$ ./bin/storage adjust
Usage Exception: Phabricator is currently in read-only mode. Use --force to override this mode.

However, some of them (status, dump, databases, etc) are read-only anyway and safe to run. Don't prompt in these cases.

Test Plan:

  • Set cluster.read-only to true.
  • Ran bin/storage dump, bin/storage status, etc. No longer received messages.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11042

Differential Revision: https://secure.phabricator.com/D15987

Details

Committed
epriestley <git@epriestley.com>May 30 2016, 18:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH10cc633b88b2: Warn and continue when failing to extract pht() strings
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb352cae97de4: Don't stop on read-only mode for read-only storage workflows (authored by epriestley <git@epriestley.com>).May 30 2016, 18:30