Homec4science

Implement a user profile image cache

Authored by epriestley <git@epriestley.com> on May 13 2015, 18:46.

Description

Implement a user profile image cache

Summary:
Ref T7707. The general form of this can probably be refined somewhat over time as we have more use cases.

I put this cache on the user object itself because we essentially always need this data and it's trivial to invalidate the cache (we can do it implicilty during reads).

Also fix an issue with short, wide images not thumbnailing properly after recent changes.

Test Plan:

  • Loaded some pages; saw caches write; saw good pictures.
  • Reloaded; saw cache reads; saw good pictures.
  • Changed profile picture; saw immediate update.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7707

Differential Revision: https://secure.phabricator.com/D12826

Details

Committed
epriestley <git@epriestley.com>May 13 2015, 20:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb06b3d79b71c: Make CSS agnostic to underlying profile image size
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb36a8fa88563: Implement a user profile image cache (authored by epriestley <git@epriestley.com>).May 13 2015, 20:38