Homec4science

Restore some minor state behaviors to Differential on EditEngine

Authored by epriestley <git@epriestley.com> on Dec 31 2016, 18:17.

Description

Restore some minor state behaviors to Differential on EditEngine

Summary:
Ref T11114. This restores:

  • Commandeering should exeucte Herald.
  • Commandeering should swap reviewers.
  • "Request Review" on an "Accepted" revision should downgrade reviewers so they have to accept again.

Test Plan:

  • Commandeered, saw Herald run and reviewers swap.
  • Requested review of an accepted revision, saw it drop down to "Needs Review" with "Accepted Prior" on the reviewer.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17118

Details

Committed
epriestley <git@epriestley.com>Dec 31 2016, 19:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9b4090af5565: Restore quote and warning behaviors to Differential EditEngine comment area
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb373dcef7448: Restore some minor state behaviors to Differential on EditEngine (authored by epriestley <git@epriestley.com>).Dec 31 2016, 19:11