Homec4science

Use viwer-based checks for application visibility when rendering home elements

Authored by epriestley <git@epriestley.com> on Mar 15 2014, 19:28.

Description

Use viwer-based checks for application visibility when rendering home elements

Summary:
Fixes T4619. Currently, even if a viewer can't see Maniphest, they'll still see empty panels on the home page. These panels will always be empty so there's no real policy violation, but it's confusing.

Longer term, dashboards should fix this.

Test Plan: Viewed home page with a user with and without permissions on the apps.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4619

Differential Revision: https://secure.phabricator.com/D8545

Details

Committed
epriestley <git@epriestley.com>Mar 15 2014, 19:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH69eab4196de4: Use modern ApplicationTransactions "no effect" stuff in Maniphest
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb3b0ef3647e8: Use viwer-based checks for application visibility when rendering home elements (authored by epriestley <git@epriestley.com>).Mar 15 2014, 19:28