Homec4science

Fix a potentially lax hash comparison

Authored by epriestley <git@epriestley.com> on Nov 10 2015, 18:51.

Description

Fix a potentially lax hash comparison

Summary: Via HackerOne. See D14025. I missed this comparison when making the original change.

Test Plan:

  • Used cat mail.txt | scripts/mail/mail_handler.php --process-duplicates to pipe mail in a whole lot of times.
  • Tried bad hashes, saw rejections.
  • Tried good hash, saw mail accepted.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14455

Details

Committed
epriestley <git@epriestley.com>Nov 10 2015, 19:22
Pushed
aubortJan 31 2017, 17:16
Parents
rPH64ad44cffb24: Always override `auth.email-domains` when running unit tests
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb3d3130b718d: Fix a potentially lax hash comparison (authored by epriestley <git@epriestley.com>).Nov 10 2015, 19:22