Homec4science

Fix two issues in owners worker

Authored by Jason Ge <jungejason@fb.com> on Jan 26 2012, 19:43.

Description

Fix two issues in owners worker

Summary:
Fix two issues in PhabricatorRepositoryCommitOwnersWorker:

  • if a commit was reviewed by some owner of the package, it should not be marked as needing audit
  • do not run herald worker when it is not needed (for example, when the worker is executed from reparse.php)

Test Plan:
reparse a commit which is reviewed by the owner of a package
and verify that it is not marked as needing audit, and herald is not
executed.

Reviewers: nh, epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1496

Details

Committed
Jason Ge <jungejason@fb.com>Jan 26 2012, 20:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3e15d7b3df16: Tweak maniphest css to make width of task transactions consistent with width of…
Branches
Unknown
Tags
Unknown

Event Timeline

Jason Ge <jungejason@fb.com> committed rPHb4053190ec83: Fix two issues in owners worker (authored by Jason Ge <jungejason@fb.com>).Jan 26 2012, 20:02