Homec4science

Make symbol linking more lenient.

Authored by Alan Huang <alanh@fb.com> on Aug 1 2012, 02:01.

Description

Make symbol linking more lenient.

Summary:
Sometimes a symbol has a nested <span> in it. Clicks on that
should count as clicks on the symbol. So keep looking for symbols among
the ancestors of the click target.

This is a silly method because I don't know if there's a more idiomatic
way to do it in Javelin.

Test Plan:
Open a Differential revision where part of a symbol is
highlighted. Click on the highlighted part. Symbol search opens.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Maniphest Tasks: T1577

Differential Revision: https://secure.phabricator.com/D3113

Details

Committed
Alan Huang <alanh@fb.com>Aug 1 2012, 02:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH606ef34d610d: Load commit branches and tags by AJAX
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPHb43e6f2a5fdb: Make symbol linking more lenient. (authored by Alan Huang <alanh@fb.com>).Aug 1 2012, 02:01