Homec4science

Order inline comments in Diffusion consistently with Differential

Authored by epriestley <git@epriestley.com> on Jan 11 2017, 23:44.

Description

Order inline comments in Diffusion consistently with Differential

Summary:
Fixes T8739. Currently, Diffusion inline comments in the timeline are sorted arbitrarily, mostly by creation order.

Instead, sort them by line number, like Differential.

Test Plan:
Made comments in "C", "B", "A" order, saw them in line order after submit:

{F2343032}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8739

Differential Revision: https://secure.phabricator.com/D17184

Details

Committed
epriestley <git@epriestley.com>Jan 11 2017, 23:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb5722a99635a: Use EditEngine stacked comments in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb471f6c07aef: Order inline comments in Diffusion consistently with Differential (authored by epriestley <git@epriestley.com>).Jan 11 2017, 23:57