Homec4science

"Merge Duplicates" in Maniphest

Authored by epriestley <git@epriestley.com> on Jun 14 2011, 16:55.

Description

"Merge Duplicates" in Maniphest

Summary:
Allow duplicate tasks to be selected and merged in Maniphest.

I didn't create a separate transaction type for this because that implies a
bunch of really complicated rules which I don't want to sort out right now
(e.g., do we need to do cycle detection for merges? If so, what do we do when we
detect a cycle?) since I think it's unnecessary to get right for the initial
implementation (my Tasks merge implementation was similar to this and worked
quite well) and if/when we eventually need the metadata to be available in a
computer-readable form that need should inform the implementation.

Plenty of room for improvement here, of course.

Test Plan:
Merged duplicate tasks, tried to perform invalid merge operations (e.g., merge a
task into itself).
Tested existing attach workflows (task -> revision, revision -> task).

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: anjali, aran
Differential Revision: 459

Details

Committed
epriestley <git@epriestley.com>Jun 15 2011, 05:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0a749ad51b69: Give unposted comments a distinct visual style
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb49c5e9762db: "Merge Duplicates" in Maniphest (authored by epriestley <git@epriestley.com>).Jun 15 2011, 05:44