Homec4science

Allow users to unset "Editor", tailor short error messages properly on settings…

Authored by epriestley <git@epriestley.com> on Jun 5 2016, 22:52.

Description

Allow users to unset "Editor", tailor short error messages properly on settings forms

Summary:
Ref T11098.

  • Allow "Editor" to be set to the empty string.
  • Don't match a validation error to a field unless the actual settings for the field and error match.

Test Plan:

  • Tried to set "Editor" to "", success.
  • Tried to set "Editor" to "javascript://", only that field got marked "Invalid".

Reviewers: avivey, chad

Reviewed By: chad

Maniphest Tasks: T11098

Differential Revision: https://secure.phabricator.com/D16051

Details

Committed
epriestley <git@epriestley.com>Jun 5 2016, 23:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4936be0868bd: Fix exception when trying to save global setting mail tags
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb4a07d528fdf: Allow users to unset "Editor", tailor short error messages properly on settings… (authored by epriestley <git@epriestley.com>).Jun 5 2016, 23:03