Homec4science

Simplify the implementation of `PhabricatorPolicyCapability` subclasses

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 25 2014, 00:25.

Description

Simplify the implementation of PhabricatorPolicyCapability subclasses

Summary: Instead of implementing the getCapabilityKey method in all subclasses of PhabricatorPolicyCapability, provide a final implementation in the base class which uses reflection. See D9837 and D9985 for similar implementations.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D10039

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jul 25 2014, 00:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc34de8361984: Rename policy capabilities
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHb4d7a9de3912: Simplify the implementation of `PhabricatorPolicyCapability` subclasses (authored by Joshua Spence <josh@joshuaspence.com>).Jul 25 2014, 00:25