Homec4science

Highlight update time in revision list

Authored by vrana <jakubv@fb.com> on Aug 20 2012, 23:05.

Description

Highlight update time in revision list

Summary:
This is another experiment for reducing reviewers response time.
I stole the idea (and colors) from ReviewBoard.
I actually quite like it (except when everything is red) and I can image that people will review just to have better color balance.

The code is not production ready for these reasons:

  • We load holidays again and again for each revision. I couldn't cache it to static variable because it could persist multiple requests, right?
  • I don't know how to expand height to the whole cell (I'm really bad in CSS).
  • CSS rules are probably in wrong file.
  • We probably want to use different colors.

This is how it looks:
{F16406}

Test Plan: Displayed revision list.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3190

Details

Committed
vrana <jakubv@fb.com>Aug 21 2012, 02:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH90f5f869ae78: Minor, updates from @chad:
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHb50cdc6e439c: Highlight update time in revision list (authored by vrana <jakubv@fb.com>).Aug 21 2012, 02:59