Homec4science

Phriction - fix edits with subscribers

Authored by Bob Trahan <btrahan@phacility.com> on Sep 5 2014, 19:48.

Description

Phriction - fix edits with subscribers

Summary: pre-patch, these fatal, since we overwrite $content to be just a string so methods fail later in the code. Instead, write a $content_str to keep $content as the proper data.

Test Plan: editing a document and on save it showed me the view page! (as opposed to fataling and staying on the eidt page)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10426

Details

Committed
Bob Trahan <btrahan@phacility.com>Sep 5 2014, 19:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3af442e4ac94: Don't require an actor in `PhabricatorFile::attachToObject()`
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHb51ae8f32d9d: Phriction - fix edits with subscribers (authored by Bob Trahan <btrahan@phacility.com>).Sep 5 2014, 19:48