Homec4science

Revamp inline commenting UI

Authored by Chad Little <chad@chadsdomain.com> on Mar 28 2015, 00:00.

Description

Revamp inline commenting UI

Summary:
Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns:

To the author:

  • The author of the diff should be able to easily identify what comments are done and not done.
  • We keep undone comments yellow
  • Clicking done turns comment block into 'unsubmitted state'

To the reviewer:

  • Easier understanding of unsubmitted states
  • All conversations to be yellow/important

Todo

  • Not all color CSS states correct
  • Unpulished checkbox support

Test Plan:
Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states.

From the Diff Author's perspective:
{F352094}

For a Diff commenter's perspective:
{F352095}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T1460, T7660, T7503

Differential Revision: https://secure.phabricator.com/D12171

Details

Committed
Chad Little <chad@chadsdomain.com>Mar 28 2015, 00:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPH174cf8239802: Provide getObjectOwnerPHID() on inline comment views
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@chadsdomain.com> committed rPHb56001457785: Revamp inline commenting UI (authored by Chad Little <chad@chadsdomain.com>).Mar 28 2015, 00:00