Homec4science

Explicitly show that "escape" closes dialogs in Phabricator

Authored by epriestley <git@epriestley.com> on Aug 2 2011, 16:00.

Description

Explicitly show that "escape" closes dialogs in Phabricator

Summary: See T382. I think bill also asked about this (T308); there's no way to
figure it out right now.
Test Plan:

  • Hit "?", verified the dialog now reveals that escape closes it.
  • Hit escape, dialog vanished.

Reviewed By: jungejason
Reviewers: fzamore, bill, codeblock, jungejason, tuomaspelkonen, aran
CC: aran, jungejason
Differential Revision: 763

Details

Committed
epriestley <git@epriestley.com>Aug 2 2011, 18:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9e2231f6d6c1: Revert "Generated code> make it harder to mark code as generated"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb5ada76ab092: Explicitly show that "escape" closes dialogs in Phabricator (authored by epriestley <git@epriestley.com>).Aug 2 2011, 18:21