Homec4science

Fix a dirname() edge case in Diffusion

Authored by epriestley <git@epriestley.com> on Sep 14 2011, 20:23.

Description

Fix a dirname() edge case in Diffusion

Summary:
dirname('x') returns '.', not '/'; this caused some issues for repositories with
files at the root.

There are some cases in the parsers where I should probably swap this out too
but I'll wait until I'm doing some more rigorous testing since that stuff is a
bit fragile and this fixes an immediate issue.

Test Plan: Ran unit tests. Viewed a file at root level in a test repository.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: nh

CC: aran, nh

Differential Revision: 932

Details

Committed
epriestley <git@epriestley.com>Sep 15 2011, 16:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH43a3f4d23400: Build an "affected path" index when attaching diffs to revisions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb64f252f8b3c: Fix a dirname() edge case in Diffusion (authored by epriestley <git@epriestley.com>).Sep 15 2011, 16:45