Phame - move over post creation and edit to use an editor
b6733e4a8643
Actions

Authored by Bob Trahan <btrahan@phacility.com> on May 15 2015, 22:07.

Description

Phame - move over post creation and edit to use an editor

Summary: This adds the bare minimum transaction set for editing posts. Fixes T7626 because now files will be correctly attached to phame posts on subsequent edits. Future work here should be adding transaction types like TYPE_BLOG for when posts are moved between blogs, TYPE_VISIBILITY for when posts are moved to published, etc. Nothing too tricky there but keeping this diff relatively small seems prudent.

Test Plan: made posts successfully. also made errors like no title, no phame title, and duplicate phame title and got correct errors. added a file to a post and verified file has phame post in "attached" tab, which should fix T7626.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7626

Differential Revision: https://secure.phabricator.com/D12864

Details

Committed

Bob Trahan <btrahan@phacility.com>

May 15 2015, 22:07

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHe3134a1d478e: This week should be marked with a bottom blue horizontal bar in Calendar month…

Branches

Unknown

Tags

Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHb6733e4a8643: Phame - move over post creation and edit to use an editor (authored by Bob Trahan <btrahan@phacility.com>).May 15 2015, 22:07

Changes (12)

				Path
	M			resources/celerity/map.php
	P			resources/sql/autopatches/20150515.phame.post.xaction.sql Copied from resources/sql/autopatches/20150514.phame.blog.xaction.sql
	M			src/__phutil_library_map__.php
	M			src/applications/phame/controller/post/PhamePostDeleteController.php
	M			src/applications/phame/controller/post/PhamePostEditController.php
	M			src/applications/phame/controller/post/PhamePostNewController.php
	M			src/applications/phame/controller/post/PhamePostViewController.php
	M			src/applications/phame/editor/PhameBlogEditor.php
	A			src/applications/phame/editor/PhamePostEditor.php
	P			src/applications/phame/query/PhamePostTransactionQuery.php Copied from src/applications/maniphest/query/ManiphestTransactionQuery.php
	M			src/applications/phame/storage/PhamePost.php
	P			src/applications/phame/storage/PhamePostTransaction.php Copied from src/applications/phame/storage/PhameBlogTransaction.php