Homec4science

"fix" github scope-upgrade flow

Authored by Aviv Eyal <avivey@gmail.com> on Jun 7 2014, 21:05.

Description

"fix" github scope-upgrade flow

Summary:
Can't say I know what I'm doing here, but this fixes an the upgrade-scope flow for landing-to-github.

Without this change, it looks like the submit button makes the browser (Chrome and msie) make the call in the background, instead of hijacking the window.
With it, it works like it should.

Test Plan: try to land with weak token, click "Refresh..", see GitHub button.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9407

Details

Committed
epriestley <git@epriestley.com>Jun 7 2014, 21:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6c48f11a07e0: Move the "Advanced Configuration" documentation.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb6bc8b8c0f8d: "fix" github scope-upgrade flow (authored by Aviv Eyal <avivey@gmail.com>).Jun 7 2014, 21:05