Extend from Phobject
b6d745b66687
Actions

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 15 2015, 10:02.

Description

Extend from Phobject

Summary: All classes should extend from some other class. See D13275 for some explanation.

Test Plan: arc unit

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13283

Details

Committed

Joshua Spence <josh@joshuaspence.com>

Jun 15 2015, 10:02

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH2d5f3d9e5aff: Fix a pht string

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHb6d745b66687: Extend from Phobject (authored by Joshua Spence <josh@joshuaspence.com>).Jun 15 2015, 10:02

Changes (197)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path
	M			src/__phutil_library_map__.php
	M			src/aphront/AphrontRequest.php
	M			src/aphront/AphrontURIMapper.php
	M			src/aphront/configuration/AphrontApplicationConfiguration.php
	M			src/aphront/response/AphrontResponse.php
	M			src/aphront/sink/AphrontHTTPSink.php
	M			src/applications/aphlict/query/AphlictDropdownDataQuery.php
	M			src/applications/audit/constants/PhabricatorAuditActionConstants.php
	M			src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
	M			src/applications/audit/constants/PhabricatorAuditStatusConstants.php
	M			src/applications/audit/storage/PhabricatorAuditInlineComment.php
	M			src/applications/auth/data/PhabricatorAuthHighSecurityToken.php
	M			src/applications/auth/provider/PhabricatorAuthProvider.php
	M			src/applications/base/PhabricatorApplication.php
	M			src/applications/cache/PhabricatorCaches.php
	M			src/applications/calendar/util/CalendarTimeUtil.php
	M			src/applications/celerity/CelerityAPI.php
	M			src/applications/celerity/CelerityResourceMap.php
	M			src/applications/celerity/CelerityResourceMapGenerator.php
	M			src/applications/celerity/CelerityResourceTransformer.php
	M			src/applications/celerity/CeleritySpriteGenerator.php
	M			src/applications/celerity/CelerityStaticResourceResponse.php
	M			src/applications/celerity/resources/CelerityResources.php
	M			src/applications/conduit/call/ConduitCall.php
	M			src/applications/conduit/protocol/ConduitAPIRequest.php
	M			src/applications/conduit/protocol/ConduitAPIResponse.php
	M			src/applications/config/check/PhabricatorSetupCheck.php
	M			src/applications/config/custom/PhabricatorConfigOptionType.php
	M			src/applications/config/issue/PhabricatorSetupIssue.php
	M			src/applications/config/json/PhabricatorConfigJSON.php
	M			src/applications/conpherence/ConpherenceTransactionRenderer.php
	M			src/applications/conpherence/constants/ConpherenceConstants.php
	M			src/applications/console/core/DarkConsoleCore.php
	M			src/applications/console/plugin/DarkConsolePlugin.php
	M			src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
	M			src/applications/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php
	M			src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php
	M			src/applications/differential/DifferentialGetWorkingCopy.php
	M			src/applications/differential/constants/DifferentialAction.php
	M			src/applications/differential/constants/DifferentialChangeType.php
	M			src/applications/differential/constants/DifferentialLintStatus.php
	M			src/applications/differential/constants/DifferentialReviewerStatus.php
	M			src/applications/differential/constants/DifferentialRevisionControlSystem.php
	M			src/applications/differential/constants/DifferentialRevisionStatus.php
	M			src/applications/differential/constants/DifferentialUnitStatus.php
	M			src/applications/differential/constants/DifferentialUnitTestResult.php
	M			src/applications/differential/landing/DifferentialLandingStrategy.php
	M			src/applications/differential/parser/DifferentialChangesetParser.php
	M			src/applications/differential/parser/DifferentialCommitMessageParser.php
	M			src/applications/differential/parser/DifferentialHunkParser.php
	M			src/applications/differential/render/DifferentialChangesetRenderer.php
	M			src/applications/differential/render/DifferentialRawDiffRenderer.php
	M			src/applications/differential/storage/DifferentialInlineComment.php
	M			src/applications/differential/storage/DifferentialReviewer.php
	M			src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php
	M			src/applications/diffusion/DiffusionLintSaveRunner.php
	M			src/applications/diffusion/data/DiffusionBrowseResultSet.php
	M			src/applications/diffusion/data/DiffusionFileContent.php
	M			src/applications/diffusion/data/DiffusionGitBranch.php
	M			src/applications/diffusion/data/DiffusionPathChange.php
	M			src/applications/diffusion/data/DiffusionRepositoryPath.php
	M			src/applications/diffusion/data/DiffusionRepositoryTag.php
	M			src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php
	M			src/applications/diffusion/query/DiffusionPathQuery.php
	M			src/applications/diffusion/query/DiffusionRenameHistoryQuery.php
	M			src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php
	M			src/applications/diffusion/query/pathid/DiffusionPathIDQuery.php
	M			src/applications/diffusion/request/DiffusionRequest.php
	M			src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php
	M			src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php
	M			src/applications/diffusion/symbol/DiffusionExternalSymbolsSource.php
	M			src/applications/diviner/atom/DivinerAtom.php
	M			src/applications/diviner/atom/DivinerAtomRef.php
	M			src/applications/diviner/atomizer/DivinerAtomizer.php
	M			src/applications/diviner/cache/DivinerDiskCache.php
	M			src/applications/diviner/publisher/DivinerPublisher.php
	M			src/applications/diviner/renderer/DivinerRenderer.php
	M			src/applications/doorkeeper/engine/DoorkeeperFeedStoryPublisher.php
	M			src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
	M			src/applications/drydock/constants/DrydockConstants.php
	M			src/applications/drydock/interface/DrydockInterface.php
	M			src/applications/drydock/util/DrydockBlueprintScopeGuard.php
	M			src/applications/fact/engine/PhabricatorFactEngine.php
	M			src/applications/fact/spec/PhabricatorFactSpec.php
	M			src/applications/feed/PhabricatorFeedStoryPublisher.php
	M			src/applications/feed/builder/PhabricatorFeedBuilder.php
	M			src/applications/feed/story/PhabricatorFeedStory.php
	M			src/applications/files/PhabricatorImageTransformer.php
	M			src/applications/files/engine/PhabricatorFileStorageEngine.php
	M			src/applications/files/query/PhabricatorFileBundleLoader.php
	M			src/applications/flag/constants/PhabricatorFlagConstants.php
	M			src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
	M			src/applications/herald/adapter/HeraldAdapter.php
	M			src/applications/herald/config/HeraldRepetitionPolicyConfig.php
	M			src/applications/herald/config/HeraldRuleTypeConfig.php
	M			src/applications/herald/engine/HeraldEffect.php
	M			src/applications/herald/engine/HeraldEngine.php
	M			src/applications/herald/extension/HeraldCustomAction.php
	M			src/applications/herald/storage/transcript/HeraldConditionTranscript.php
	M			src/applications/herald/storage/transcript/HeraldObjectTranscript.php
	M			src/applications/herald/storage/transcript/HeraldRuleTranscript.php
	M			src/applications/lipsum/generator/PhabricatorTestDataGenerator.php
	M			src/applications/lipsum/image/PhabricatorLipsumArtist.php
	M			src/applications/maniphest/constants/ManiphestConstants.php
	M			src/applications/maniphest/export/ManiphestExcelFormat.php
	M			src/applications/metamta/adapter/PhabricatorMailImplementationAdapter.php
	M			src/applications/metamta/constants/MetaMTAConstants.php
	M			src/applications/metamta/contentsource/PhabricatorContentSource.php
	M			src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
	M			src/applications/metamta/query/PhabricatorMetaMTAActor.php
	M			src/applications/metamta/receiver/PhabricatorMailReceiver.php
	M			src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
	M			src/applications/metamta/storage/PhabricatorMetaMTAAttachment.php
	M			src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
	M			src/applications/metamta/view/PhabricatorMetaMTAMailSection.php
	M			src/applications/multimeter/data/MultimeterControl.php
	M			src/applications/notification/builder/PhabricatorNotificationBuilder.php
	M			src/applications/notification/client/PhabricatorNotificationClient.php
	M			src/applications/oauthserver/PhabricatorOAuthServer.php
	M			src/applications/oauthserver/PhabricatorOAuthServerScope.php
	M			src/applications/owners/query/PhabricatorOwnerPathQuery.php
	M			src/applications/phame/skins/PhameSkinSpecification.php
	M			src/applications/phid/PhabricatorObjectHandle.php
	M			src/applications/phid/PhabricatorPHIDConstants.php
	M			src/applications/phid/handle/view/PhabricatorHandleObjectSelectorDataView.php
	M			src/applications/phid/query/PhabricatorObjectListQuery.php
	M			src/applications/phid/storage/PhabricatorPHID.php
	M			src/applications/phid/type/PhabricatorPHIDType.php
	M			src/applications/phortune/cart/PhortuneCartImplementation.php
	M			src/applications/phortune/constants/PhortuneConstants.php
	M			src/applications/phortune/product/PhortuneProductImplementation.php
	M			src/applications/phortune/provider/PhortunePaymentProvider.php
	M			src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php
	M			src/applications/phortune/view/PhortuneCreditCardForm.php
	M			src/applications/phriction/constants/PhrictionConstants.php
	M			src/applications/policy/__tests__/PhabricatorPolicyTestObject.php
	M			src/applications/policy/constants/PhabricatorPolicyConstants.php
	M			src/applications/policy/filter/PhabricatorPolicyFilter.php
	M			src/applications/policy/rule/PhabricatorPolicyRule.php
	M			src/applications/ponder/constants/PonderConstants.php
	M			src/applications/project/constants/PhabricatorProjectStatus.php
	M			src/applications/project/view/ProjectBoardTaskCard.php
	M			src/applications/releeph/commitfinder/ReleephCommitFinder.php
	M			src/applications/releeph/constants/ReleephRequestStatus.php
	M			src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
	M			src/applications/releeph/field/selector/ReleephFieldSelector.php
	M			src/applications/releeph/view/branch/ReleephBranchTemplate.php
	M			src/applications/repository/constants/PhabricatorRepositoryType.php
	M			src/applications/repository/engine/PhabricatorRepositoryCommitRef.php
	M			src/applications/repository/engine/PhabricatorRepositoryEngine.php
	M			src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php
	M			src/applications/search/constants/PhabricatorSearchRelationship.php
	M			src/applications/search/engine/PhabricatorJumpNavHandler.php
	M			src/applications/search/engine/PhabricatorSearchEngine.php
	M			src/applications/search/index/PhabricatorSearchAbstractDocument.php
	M			src/applications/search/index/PhabricatorSearchIndexer.php
	M			src/applications/settings/panel/PhabricatorSettingsPanel.php
	M			src/applications/subscriptions/view/SubscriptionListDialogBuilder.php
	M			src/applications/subscriptions/view/SubscriptionListStringBuilder.php
	M			src/applications/system/action/PhabricatorSystemAction.php
	M			src/applications/transactions/constants/PhabricatorTransactions.php
	M			src/applications/typeahead/storage/PhabricatorTypeaheadResult.php
	M			src/applications/uiexample/examples/PhabricatorUIExample.php
	M			src/infrastructure/customfield/field/PhabricatorCustomField.php
	M			src/infrastructure/customfield/field/PhabricatorCustomFieldAttachment.php
	M			src/infrastructure/daemon/bot/PhabricatorBotMessage.php
	M			src/infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php
	M			src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
	M			src/infrastructure/daemon/bot/target/PhabricatorBotTarget.php
	M			src/infrastructure/daemon/control/PhabricatorDaemonReference.php
	M			src/infrastructure/daemon/workers/PhabricatorWorker.php
	M			src/infrastructure/diff/PhabricatorDifferenceEngine.php
	M			src/infrastructure/edges/constants/PhabricatorEdgeConstants.php
	M			src/infrastructure/env/PhabricatorConfigSource.php
	M			src/infrastructure/env/PhabricatorEnv.php
	M			src/infrastructure/env/PhabricatorScopedEnv.php
	M			src/infrastructure/events/PhabricatorEventEngine.php
	M			src/infrastructure/javelin/Javelin.php
	M			src/infrastructure/log/PhabricatorAccessLog.php
	M			src/infrastructure/markup/PhabricatorMarkupEngine.php
	M			src/infrastructure/markup/PhabricatorMarkupOneOff.php
	M			src/infrastructure/markup/PhabricatorSyntaxHighlighter.php
	M			src/infrastructure/query/PhabricatorQuery.php
	M			src/infrastructure/sms/adapter/PhabricatorSMSImplementationAdapter.php
	M			src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php
	M			src/infrastructure/storage/lisk/LiskDAO.php
	M			src/infrastructure/storage/lisk/LiskDAOSet.php
	M			src/infrastructure/storage/lisk/PhabricatorLiskSerializer.php
	M			src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php
	M			src/infrastructure/storage/management/PhabricatorStoragePatch.php
	M			src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
	M			src/infrastructure/testing/fixture/PhabricatorStorageFixtureScopeGuard.php
	M			src/infrastructure/time/PhabricatorTime.php
	M			src/infrastructure/time/PhabricatorTimeGuard.php
	M			src/infrastructure/util/PhabricatorSlug.php
	M			src/view/control/PhabricatorObjectSelectorDialog.php
	M			src/view/phui/PHUI.php