Homec4science

Raise a setup fatal for 'disable_functions' or 'disable_classes'

Authored by epriestley <git@epriestley.com> on Aug 13 2013, 19:11.

Description

Raise a setup fatal for 'disable_functions' or 'disable_classes'

Summary:
Fixes T3709. PHP has two configuration options ('disable_functions', 'disable_classes') which allow functions and classes to be blacklisted at runtime.

Since these break things in an unclear way, raise a setup fatal if they are set.

We take a slightly more tailored approach to these in phd already, but I'd rather try just saying "no, this is bad" and see if we can get away with it. I suspect we can, and there's no legitimate reason to blacklist functions given that Phabricator must have access to, e.g., proc_open().

Test Plan: {F54058}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3709

Differential Revision: https://secure.phabricator.com/D6739

Details

Committed
epriestley <git@epriestley.com>Aug 13 2013, 19:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf37b315decf5: Correct switched-around configuration descriptions for metamta.herald.show…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb7387f314b24: Raise a setup fatal for 'disable_functions' or 'disable_classes' (authored by epriestley <git@epriestley.com>).Aug 13 2013, 19:11