Move Herald rule querying into HeraldRuleQuery
b767bd3f2d9d
Actions

Authored by epriestley <git@epriestley.com> on Aug 6 2013, 20:32.

Description

Move Herald rule querying into HeraldRuleQuery

Summary: Ref T2769. The HeraldRule class has some query logic; move it into HeraldRuleQuery. Also some minor cleanup.

Test Plan: Ran test console, created a new revision, used reparse.php --herald. Verified rules triggered correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2769

Committed

epriestley <git@epriestley.com>

Aug 8 2013, 03:04

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPHb767bd3f2d9d: Move Herald rule querying into HeraldRuleQuery (authored by epriestley <git@epriestley.com>).Aug 8 2013, 03:04

				Path
	M			src/applications/herald/adapter/HeraldCommitAdapter.php
	M			src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
	M			src/applications/herald/controller/HeraldTestConsoleController.php
	M			src/applications/herald/engine/HeraldEngine.php
	M			src/applications/herald/query/HeraldRuleQuery.php
	M			src/applications/herald/storage/HeraldRule.php
	M			src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php