Homec4science

Fix improper selection of the chunk engine as a writable engine

Authored by epriestley <git@epriestley.com> on Mar 19 2015, 03:06.

Description

Fix improper selection of the chunk engine as a writable engine

Summary:
Fixes T7621. The engine selection code started out making sense, but didn't make as much sense by the time I was done with it.

Specifically, from the vanilla file upload, we may incorrectly try to write directly to the chunk storage engine. This is incorrect, and produces a confusing/bad error.

Make chunk storage engines explicit and don't try to do single-file one-shot writes to them.

Test Plan:

  • Tried to upload a large file with vanilla uploader, got better error message.
  • Uploaded small and large files with drag and drop.
  • Viewed FilesHelp/Options.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7621

Differential Revision: https://secure.phabricator.com/D12110

Details

Committed
epriestley <git@epriestley.com>Mar 19 2015, 03:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbd2eaad04f03: Add "phabricator.silent" for stopping all outbound events from an install
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb7fa55ff9396: Fix improper selection of the chunk engine as a writable engine (authored by epriestley <git@epriestley.com>).Mar 19 2015, 03:06