Homec4science

Detect if a commit *really* doesn't exist and 4oh4 from Diffusion commit view

Authored by Bob Trahan <bob.trahan@gmail.com> on Aug 9 2012, 18:27.

Description

Detect if a commit *really* doesn't exist and 4oh4 from Diffusion commit view

Summary: rather than showing an erroneous "we still parsing" message.

Test Plan: for each version control system, typed in a garbage URL and got a 4oh4. (note this actually fails for SVN -- see comment about how my code fails atm -- and DiffusionGitRequest seems to pick off this error in advance and returns an AphrontUsageException.)

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1624

Differential Revision: https://secure.phabricator.com/D3201

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Aug 9 2012, 18:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd32926e5f70e: Work-in-progress schema for Facts app
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHb86d995b4030: Detect if a commit *really* doesn't exist and 4oh4 from Diffusion commit view (authored by Bob Trahan <bob.trahan@gmail.com>).Aug 9 2012, 18:27