Homec4science

Fix bugs when saving package changes due to commit changes

Authored by Nick Harper <nharper@fb.com> on Dec 19 2012, 19:53.

Description

Fix bugs when saving package changes due to commit changes

Summary:
Because of the way PhabricatorOwnersPackage works, the code to save package
changes when parsing commit changes was raising a few undefined index errors,
and was throwing an exception trying to call a method on null (because not
all of the phids related to the package had their handles loaded). This fix
doesn't load the missing handles, it just avoids trying to use them.

Test Plan:
./scripts/repository/reparse.php on a commit with path changes that triggered
a package change

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4236

Details

Committed
Nick Harper <nharper@fb.com>Dec 19 2012, 19:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH93c40307329c: Fix IRC bot Dxxx Conduit call.
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPHb8d372c4bc3e: Fix bugs when saving package changes due to commit changes (authored by Nick Harper <nharper@fb.com>).Dec 19 2012, 19:53