Homec4science

Fix scrollbar being cut off at end of gutter

Authored by epriestley <git@epriestley.com> on Mar 7 2015, 18:53.

Description

Fix scrollbar being cut off at end of gutter

Summary:
The "mlb" on the left nav creates a phantom bottom margin which gives the content measurable height but not scrollable height. Replace it with "plb" (padding) instead.

The 2px-spacer calculation was also not quite correct.

Test Plan:

  • Viewed pages with navs; padding vs margin didn't seem to make any other differences.
  • Scrollbar now stops in the right place in Safari, Chrome, Firefox.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12007

Details

Committed
epriestley <git@epriestley.com>Mar 7 2015, 18:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH076cc6ed7ef8: Change setErrorView to setInfoView in PHUIObjectBoxView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb8ed980d3dc5: Fix scrollbar being cut off at end of gutter (authored by epriestley <git@epriestley.com>).Mar 7 2015, 18:53