Homec4science

Fix two Passphrase credential type issues

Authored by epriestley <git@epriestley.com> on May 26 2014, 14:46.

Description

Fix two Passphrase credential type issues

Summary:
Fixes T4991. Two issues:

  • These error messages pass an object to "%s", when they mean to pass a type constant.
  • The check for noncreatable credentials is incorrectly in the "edit" branch of the controller.

Test Plan:

  • Edited a "SSH Key on disk" credential.
  • Tried to create a credential with a bogus type.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T4991

Differential Revision: https://secure.phabricator.com/D9299

Details

Committed
epriestley <git@epriestley.com>May 26 2014, 14:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb7a8c0b20004: Fix references to `set-config --show` in docs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb93c2f68521d: Fix two Passphrase credential type issues (authored by epriestley <git@epriestley.com>).May 26 2014, 14:46