Homec4science

Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing…

Authored by John Mullanaphy <john@jo.mu> on Jan 9 2014, 19:35.

Description

Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing an error when trying to report an error.

Summary:
Phabricator was going to give me an error message via commit_hook.php, unfortunately said error wasn't being set since
\$callsign was undefined. So, just changed \$callsign to \$argv[1] and now I get the appropriate commit.

Test Plan:

  1. Add commit_hook.php to an SVN pre-commit.
  2. Set the SVN to be hosted off of Phabricator.
  3. Attempt to commit to commit to SVN repository.

Expected: Error message saying that the repository isn't hosted on Phabricator
Results: Error message saying undefined function.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7920

Details

Committed
epriestley <git@epriestley.com>Jan 9 2014, 19:36
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3c5756adf977: Clean up AphrontError boxes, Diffusion Headers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb960c8114b50: Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing… (authored by John Mullanaphy <john@jo.mu>).Jan 9 2014, 19:36