Homec4science

Restore a more surgical workflow/target check

Authored by epriestley <git@epriestley.com> on Oct 17 2012, 17:28.

Description

Restore a more surgical workflow/target check

Summary:
D3707 removed some overbroad rules for when we trigger workflows, but there is still one case we should check for -- an <a /> without workflow inside a <form /> with workflow. This occurs in, e.g., the "help" button in Remarkup.

If the node with workflow isn't a link, don't trigger workflow. This should allow the <a><img /></a> case to keep working properly.

Test Plan: Clicked "?" in remarkup bar.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3722

Details

Committed
epriestley <git@epriestley.com>Oct 17 2012, 17:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH602d94fd876b: Fix a fatal in "create subtask"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb986f9f73107: Restore a more surgical workflow/target check (authored by epriestley <git@epriestley.com>).Oct 17 2012, 17:28