Homec4science

Diffusion - fix commits not importing fully

Authored by Bob Trahan <btrahan@phacility.com> on Oct 17 2014, 18:41.

Description

Diffusion - fix commits not importing fully

Summary: Fixes T6336. Turns out that the function to update the import status updates that database and doesn't update the object. If the object doesn't get the pertinent update AND there's a herald rule that runs, then the object is later re-saved without ever getting the update flag.

Test Plan: logic in the ole sandbox and going to push it to prod and run re-parse on impacted commits

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley, chad

Maniphest Tasks: T6336

Differential Revision: https://secure.phabricator.com/D10723

Details

Committed
Bob Trahan <btrahan@phacility.com>Oct 17 2014, 18:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe6d946661ddf: Minor, fix some missing column schema
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHba2963ecb3bb: Diffusion - fix commits not importing fully (authored by Bob Trahan <btrahan@phacility.com>).Oct 17 2014, 18:41