Homec4science

Correct a mask config value

Authored by epriestley <git@epriestley.com> on Apr 30 2011, 07:20.

Description

Correct a mask config value

Summary:
The correct name of this key is 'github.application-secret', not
'github.secret'. Make DarkConsole check that all the masked keys exist to
prevent this from happening again. This isn't super important since this
is just intended to protected against casual security lapses (taking a
screenshot with DarkCnosole's "Config" tab open, for instance) but it's easy
to check for so it seems worthwhile to get right.

Test Plan:
Loaded page without the actual config file change, got an exception.
Fixed the config, reloaded the page, good news goats (really trying to get this
to catch on since goats are adorable).

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran
Differential Revision: 189

Details

Committed
epriestley <git@epriestley.com>Apr 30 2011, 20:56
Pushed
aubortJan 31 2017, 17:16
Parents
rPH94df24977598: Improve schema upgrade workflow for unprivileged users
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbaab61a01e44: Correct a mask config value (authored by epriestley <git@epriestley.com>).Apr 30 2011, 20:56