Homec4science

Fix a possible fatal on the first push to a cluster repository

Authored by epriestley <git@epriestley.com> on May 24 2016, 02:13.

Description

Fix a possible fatal on the first push to a cluster repository

Summary:
Fixes T11020. I think this resolves things -- $new_version (set above) should be used, not $new_log directly.

Specifically, we would get into trouble if the initial push failed for some reason (working copy not initialized yet, commit hook rejected, etc).

Test Plan: Made a bad push to a new repository. Saw it freeze before the patch and succeed afterwards.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11020

Differential Revision: https://secure.phabricator.com/D15969

Details

Committed
epriestley <git@epriestley.com>May 24 2016, 02:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH725d60eb4aa8: Fix "Reviewers" validation issue with empty reviewers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbb16a1b0e2a8: Fix a possible fatal on the first push to a cluster repository (authored by epriestley <git@epriestley.com>).May 24 2016, 02:54