Homec4science

Reduce garbage-level of Drydock Allocator implementation

Authored by epriestley <git@epriestley.com> on Sep 21 2015, 13:43.

Description

Reduce garbage-level of Drydock Allocator implementation

Summary:
Ref T9253. The Drydock allocator is very pseudocodey right now. Particularly, it was written before Blueprints were concrete.

Reorganize it to make its responsibilities and error handling behaviors more clear.

In particular, the Allocator does not manage locks. It's primarily trying to reject allocations which can not possibly work. Blueprints are responsible for locks. See some discussion in D10304.

NOTE: This code probably doesn't work as written, see future diffs.

Test Plan: See future diffs.

Reviewers: hach-que, chad

Reviewed By: hach-que, chad

Subscribers: cburroughs

Maniphest Tasks: T9253

Differential Revision: https://secure.phabricator.com/D14114

Details

Committed
epriestley <git@epriestley.com>Sep 21 2015, 13:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5362d3366ce2: Modernize Drydock Query + Attach code
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbb28f94f9b64: Reduce garbage-level of Drydock Allocator implementation (authored by epriestley <git@epriestley.com>).Sep 21 2015, 13:43