Homec4science

(stable) When a field isn't lockable, just freeze the lock status instead of…

Authored by epriestley <git@epriestley.com> on Nov 17 2016, 23:50.

Description

(stable) When a field isn't lockable, just freeze the lock status instead of removing any lock

Summary:
See downstream issue here: https://phabricator.wikimedia.org/T150992

In at least one case (project milestones) we have a locked, non-lockable field. This means "this is locked, and you can't change the fact that it is locked".

At least for now, preserve this behavior.

Test Plan: Created a new milestone of an existing project. This worked correctly with the patch.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16895

Details

Committed
epriestley <git@epriestley.com>Nov 18 2016, 00:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7ebc47d906fe: (stable) Fix an EditEngine issue with unlocking fields which can't be locked
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbb6bd8c8d034: (stable) When a field isn't lockable, just freeze the lock status instead of… (authored by epriestley <git@epriestley.com>).Nov 18 2016, 00:04