Homec4science

Fail gracefully on bad API call when building commit mail

Authored by epriestley <git@epriestley.com> on Jun 17 2015, 01:06.

Description

Fail gracefully on bad API call when building commit mail

Summary:
Ref T8574. This could fail because the target is disabled (as here), or doesn't have access to the API, or the API request needs to be satisfied by a different host which isn't available.

In any of these cases, just show the failure and continue generating the mail. This field isn't important enough to block the mail, and many of these errors are permanent.

(I'll follow up on T8574 with some more permanent ideas to address this class of issue.)

Test Plan: Faked API call failure, generated mail, saw clean generation of mail with a failure message.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8574

Differential Revision: https://secure.phabricator.com/D13319

Details

Committed
epriestley <git@epriestley.com>Jun 17 2015, 01:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH42170ab151a9: Change text ADD_CC and REMOVE_CC actions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbb7f2ea9055c: Fail gracefully on bad API call when building commit mail (authored by epriestley <git@epriestley.com>).Jun 17 2015, 01:06