Homec4science

Allow upload of arbitrary text files

Authored by epriestley <git@epriestley.com> on Jul 28 2015, 17:04.

Description

Allow upload of arbitrary text files

Summary:
Fixes T8984. Because of how drag-and-drop upload works, the text file with content code is interpreted as a forbidden variable. Disable this check for the drop upload controller.

(The risk here is a general one where the controller redirects and bundles paramters; this controller does not do that, so it's safe to make this change.)

Test Plan: Uploaded a text file containing only the string "code" (no quotes) by using drag-and-drop.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8984

Differential Revision: https://secure.phabricator.com/D13744

Details

Committed
epriestley <git@epriestley.com>Jul 28 2015, 17:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHeb152d3053a0: Allow Tokens on Badge
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbbc1074cedfc: Allow upload of arbitrary text files (authored by epriestley <git@epriestley.com>).Jul 28 2015, 17:04